Skip to content

Fix playground precommit test failure - #39062

Merged
shunping merged 2 commits into
apache:masterfrom
shunping:debug-playground-failure
Jun 22, 2026
Merged

Fix playground precommit test failure#39062
shunping merged 2 commits into
apache:masterfrom
shunping:debug-playground-failure

Conversation

@shunping

@shunping shunping commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator

We are getting the following error when running playground precommit test (https://github.com/apache/beam/actions/runs/27978705305/job/82802995457?pr=39062).

Error:  life_cycle_setuper_test.go:344: Setup() error = error during create necessary files for the Scio sdk: exit status 1: [error] sbt 2.x requires JDK 17 or above, but you have JDK 11
            /runner/_work/beam/beam/playground/backend/internal/setup_tools/life_cycle/workingDir/new_scio_project.sh: line 23: scio/build.sbt: No such file or directory
            /runner/_work/beam/beam/playground/backend/internal/setup_tools/life_cycle/workingDir/new_scio_project.sh: line 24: scio/build.sbt: No such file or directory
            /runner/_work/beam/beam/playground/backend/internal/setup_tools/life_cycle/workingDir/new_scio_project.sh: line 25: scio/build.sbt: No such file or directory
            , wantErr false

This is due to the recent release of sbt 2.x (https://www.scala-sbt.org/download/), which requires JDK 17.

@github-actions github-actions Bot added the build label Jun 22, 2026
@shunping shunping changed the title Debug playground failure Fix playground test failure Jun 22, 2026
@shunping shunping changed the title Fix playground test failure Fix playground precommit test failure Jun 22, 2026
@shunping

shunping commented Jun 22, 2026 •
edited
Loading

Copy link
Copy Markdown
Collaborator Author

r: @derrickaw

Notice the test will still fail because we are modifying the workflow yaml. The fix should take effect after the PR is merged.

@shunping
shunping marked this pull request as ready for review June 22, 2026 20:06
@gemini-code-assist

gemini-code-assist Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Summary of Changes

Hello, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request resolves a regression in the playground precommit test suite triggered by the recent sbt 2.x release. The update introduced a dependency on JDK 17, which was previously incompatible with the existing test environment configuration.

Highlights

  • Test Environment Fix: Addressed a precommit test failure caused by the sbt 2.x update, which requires JDK 17 or higher.
  • Code Cleanup: Reorganized import statements in the life cycle test file for better consistency.
New Features

🧠 You can now enable Memory (public preview) to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console.

Ignored Files
  • Ignored by pattern: .github/workflows/** (1)
    • .github/workflows/beam_Playground_Precommit.yml
Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature Command Description
Code Review /gemini review Performs a code review for the current pull request in its current state.
Pull Request Summary /gemini summary Provides a summary of the current pull request in its current state.
Comment @gemini-code-assist Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help /gemini help Displays a list of available commands.

Customization

To customize the Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counterproductive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for GitHub and other Google products, sign up here.

Footnotes

  1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

@github-actions

github-actions Bot commented Jun 22, 2026

Copy link
Copy Markdown
Contributor

Stopping reviewer notifications for this pull request: review requested by someone other than the bot, ceding control. If you'd like to restart, comment assign set of reviewers

gemini-code-assist[bot]
gemini-code-assist Bot reviewed Jun 22, 2026
View reviewed changes

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request reorganizes the import statements in life_cycle_setuper_test.go to group the internal emulators package separately from the standard library imports. There are no review comments, and I have no feedback to provide.

Important

The consumer version of Gemini Code Assist on GitHub is being sunset. Starting June 18, 2026, new organization installations will be blocked, and all code review activity will officially cease on July 17, 2026.
For more details on the timeline and next steps, please review the Help Documentation.

@shunping

shunping commented Jun 22, 2026

Copy link
Copy Markdown
Collaborator Author

Successful run: https://github.com/apache/beam/actions/runs/27984341317

@shunping
shunping merged commit 9868954 into apache:master Jun 22, 2026
12 of 13 checks passed
@shunping shunping mentioned this pull request Jun 23, 2026
Merged
ash6898 pushed a commit to ash6898/beam that referenced this pull request Jun 28, 2026
@shunping @ash6898
Fix playground precommit test failure (apache#39062)
319375c 
* Debug playground failure

* Restore the error message and update java version.
ash6898 pushed a commit to ash6898/beam that referenced this pull request Jun 29, 2026
@shunping @ash6898
Fix playground precommit test failure (apache#39062)
5df98af 
* Debug playground failure

* Restore the error message and update java version.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@derrickaw derrickaw derrickaw approved these changes
+1 more reviewer
@gemini-code-assist gemini-code-assist[bot] gemini-code-assist[bot] left review comments
Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

build

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@shunping @derrickaw